Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 598563002: Switch to keyboard mic layout for WebRTC if conditions are met. (Closed)

Created:
6 years, 3 months ago by Henrik Grunell
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@activate_kmic_if_layout
Project:
chromium
Visibility:
Public.

Description

Switch to keyboard mic layout for WebRTC if conditions are met. Conditions: * Track processing is enabled. * Experimental constraint is set. * Keyboard mic is supported (reported via effect). * The ordinary layout is stereo. This CL will be landed last of the keyboard mic support CLs. BUG=345296 Committed: https://crrev.com/041040af18ab3e1c8c67dfecdf5eddfbedf44cc7 Cr-Commit-Position: refs/heads/master@{#296689}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Patch Set 3 : Code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/renderer/media/webrtc_audio_capturer.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Henrik Grunell
6 years, 3 months ago (2014-09-23 13:26:41 UTC) #2
Henrik Grunell
6 years, 3 months ago (2014-09-23 13:42:15 UTC) #4
Henrik Grunell
Removed Per, added Tommi. Please review Tommi or Shijing whoever makes it first. :)
6 years, 3 months ago (2014-09-23 15:01:55 UTC) #6
tommi (sloooow) - chröme
first! lgtm w/nit https://codereview.chromium.org/598563002/diff/1/content/renderer/media/webrtc_audio_capturer.cc File content/renderer/media/webrtc_audio_capturer.cc (right): https://codereview.chromium.org/598563002/diff/1/content/renderer/media/webrtc_audio_capturer.cc#newcode166 content/renderer/media/webrtc_audio_capturer.cc:166: media::AudioParameters::KEYBOARD_MIC)) { nit: this seems like ...
6 years, 3 months ago (2014-09-23 17:27:00 UTC) #7
Henrik Grunell
https://codereview.chromium.org/598563002/diff/1/content/renderer/media/webrtc_audio_capturer.cc File content/renderer/media/webrtc_audio_capturer.cc (right): https://codereview.chromium.org/598563002/diff/1/content/renderer/media/webrtc_audio_capturer.cc#newcode166 content/renderer/media/webrtc_audio_capturer.cc:166: media::AudioParameters::KEYBOARD_MIC)) { On 2014/09/23 17:27:00, tommi wrote: > nit: ...
6 years, 2 months ago (2014-09-25 10:08:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598563002/40001
6 years, 2 months ago (2014-09-25 10:09:48 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 87760b831c443ca23ae0a23c8777350a3e873efa
6 years, 2 months ago (2014-09-25 11:00:07 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 11:00:44 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/041040af18ab3e1c8c67dfecdf5eddfbedf44cc7
Cr-Commit-Position: refs/heads/master@{#296689}

Powered by Google App Engine
This is Rietveld 408576698