Source/modules/websockets/NewWebSocketChannelImpl.cpp - Issue 598533003: Revert "Mixed Content: Make MixedContentChecker completely static."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/NewWebSocketChannelImpl.cpp

Issue 598533003: Revert "Mixed Content: Make MixedContentChecker completely static." (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/websockets/NewWebSocketChannelImpl.cpp

diff --git a/Source/modules/websockets/NewWebSocketChannelImpl.cpp b/Source/modules/websockets/NewWebSocketChannelImpl.cpp

index a8afbd5e231569e43fe9fd3bbf891d72140705e8..60a2766ee8d81f430a05ab226571fe86060ebe95 100644

--- a/Source/modules/websockets/NewWebSocketChannelImpl.cpp

+++ b/Source/modules/websockets/NewWebSocketChannelImpl.cpp

@@ -136,7 +136,7 @@ bool NewWebSocketChannelImpl::connect(const KURL& url, const String& protocol)

return false;

if (executionContext()->isDocument() && document()->frame()) {

- if (MixedContentChecker::shouldBlockWebSocket(document()->frame(), url))

+ if (!document()->frame()->loader().mixedContentChecker()->canConnectInsecureWebSocket(document()->securityOrigin(), url))

return false;

}

if (MixedContentChecker::isMixedContent(document()->securityOrigin(), url)) {

« no previous file with comments | « Source/modules/websockets/MainThreadWebSocketChannel.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »