Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 598523002: Move test for reduction of Math.max to unittest. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move test for reduction of Math.max to unittest. R=bmeurer@chromium.org TEST=compiler-unittests/JSBuiltinReducerTest.MathMax Committed: https://code.google.com/p/v8/source/detail?r=24147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -42 lines) Patch
M src/compiler/graph-unittest.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/graph-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer-unittest.cc View 2 chunks +68 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-23 11:27:37 UTC) #1
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-23 11:30:06 UTC) #2
Michael Starzinger
6 years, 3 months ago (2014-09-23 11:40:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698