Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 598503002: Revert of RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout (Closed)

Created:
6 years, 3 months ago by alancutter (OOO until 2018)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout (patchset #1 id:1 of https://codereview.chromium.org/414123006/) Reason for revert: Reverting this change fixes stable blocking bug: https://crbug.com/413553 Original issue's description: > RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout > > This CL swiches RenderBlock::layoutPositionedObjects from using setNeedsLayout > to setNeedsPositionedMovementLayout, as indicated by the FIXME comment and > associated bug. The test failure mentioned in the bug is no longer a problem. > > BUG=350756 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179289 TBR=leviw@chromium.org,dsinclair@chromium.org,jchaffraix@chromium.org,abarth@chromium.org BUG=350756, 413553 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182490

Patch Set 1 #

Patch Set 2 : Use git revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
A LayoutTests/platform/android/fast/repaint/bugzilla-6388-expected.txt View 1 1 chunk +37 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
alancutter (OOO until 2018)
Created Revert of RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout
6 years, 3 months ago (2014-09-23 10:35:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598503002/1
6 years, 3 months ago (2014-09-23 10:36:06 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/repaint/bugzilla-6388-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-23 10:36:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598503002/140001
6 years, 3 months ago (2014-09-23 10:39:01 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 12:12:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:140001) as 182490

Powered by Google App Engine
This is Rietveld 408576698