Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 598493002: Cleanup: Remove the instances of "rm_binaries.py" from 'src/tools/gn/bin' (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove the instances of "rm_binaries.py" from 'src/tools/gn/bin'. The GN binaries have moved to src/buildtools. So, this script was removing GN binaries from tools/gn/bin that aren't used anymore. It was kept with the same intent till july 2014 (expected), and now think so, it is the good time to remove this script. BUG= Committed: https://crrev.com/5e4a92f923982405e20195e9de9f675c41e0748c Cr-Commit-Position: refs/heads/master@{#296344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D tools/gn/bin/rm_binaries.py View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anujsharma
brettw@chromium.org: Please review changes in tools/gn/bin module darin@chromium.org: Please review changes in DEPS
6 years, 3 months ago (2014-09-23 11:24:40 UTC) #2
anujsharma
On 2014/09/23 11:24:40, anujsharma wrote: > mailto:brettw@chromium.org: Please review changes in tools/gn/bin module > > ...
6 years, 3 months ago (2014-09-23 11:25:28 UTC) #3
brettw
thanks. LGTM
6 years, 2 months ago (2014-09-23 20:15:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598493002/1
6 years, 2 months ago (2014-09-24 03:13:29 UTC) #6
anujsharma
On 2014/09/24 03:13:29, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-09-24 03:29:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4866594df63c9e8c664f02343aeb07af87ce79d3
6 years, 2 months ago (2014-09-24 04:10:03 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 04:10:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e4a92f923982405e20195e9de9f675c41e0748c
Cr-Commit-Position: refs/heads/master@{#296344}

Powered by Google App Engine
This is Rietveld 408576698