content/renderer/pepper/pepper_media_stream_audio_track_host.cc - Issue 598483002: Fix WeakPtrFactory member ordering in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_media_stream_audio_track_host.cc

Issue 598483002: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed order of friend class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_media_stream_audio_track_host.cc

diff --git a/content/renderer/pepper/pepper_media_stream_audio_track_host.cc b/content/renderer/pepper/pepper_media_stream_audio_track_host.cc

index 021a74069a44937a859fa322aa8a66eb4ddbb79d..72279f652900a42b057ab63455de1d00ef67aef8 100644

--- a/content/renderer/pepper/pepper_media_stream_audio_track_host.cc

+++ b/content/renderer/pepper/pepper_media_stream_audio_track_host.cc

@@ -72,10 +72,10 @@ PepperMediaStreamAudioTrackHost::AudioSink::AudioSink(

active_buffer_offset_(0),

buffers_generation_(0),

main_message_loop_proxy_(base::MessageLoopProxy::current()),

- weak_factory_(this),

number_of_buffers_(kDefaultNumberOfBuffers),

bytes_per_second_(0),

- user_buffer_duration_(kDefaultDuration) {}

+ user_buffer_duration_(kDefaultDuration),

+ weak_factory_(this) {}

PepperMediaStreamAudioTrackHost::AudioSink::~AudioSink() {

DCHECK_EQ(main_message_loop_proxy_, base::MessageLoopProxy::current());