Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 598463004: Try swarming base_unittests, browser_tests, content_browsertests, interactive_ui_tests, sync_integr… (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Try swarming base_unittests, browser_tests, content_browsertests, interactive_ui_tests, sync_integration_tests and unit_tests on debug Linux bots. BUG=414808 TBR=maruel@chromium.org Committed: https://crrev.com/a7a6eca707e8ffa38635eb425fd22169c75c4fd9 Cr-Commit-Position: refs/heads/master@{#296409}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M testing/buildbot/chromium.linux.json View 1 4 chunks +38 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
If this sticks, I'll remove the builder/tester split and then do the same for release.
6 years, 3 months ago (2014-09-24 14:38:42 UTC) #3
jam
Committed patchset #2 (id:60001) manually as a7a6eca (presubmit successful).
6 years, 3 months ago (2014-09-24 14:41:56 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a7a6eca707e8ffa38635eb425fd22169c75c4fd9 Cr-Commit-Position: refs/heads/master@{#296409}
6 years, 3 months ago (2014-09-24 14:41:59 UTC) #5
M-A Ruel
On 2014/09/24 14:38:42, jam wrote: > If this sticks, I'll remove the builder/tester split and ...
6 years, 3 months ago (2014-09-24 14:45:57 UTC) #6
M-A Ruel
lgtm
6 years, 3 months ago (2014-09-24 14:46:05 UTC) #7
jam
6 years, 3 months ago (2014-09-24 14:51:21 UTC) #8
Message was sent while issue was closed.
On 2014/09/24 14:45:57, M-A Ruel wrote:
> On 2014/09/24 14:38:42, jam wrote:
> > If this sticks, I'll remove the builder/tester split and then do the same
for
> > release.
> 
> We'll wait for a few stability features to be implemented in Swarming before
> builder/tester split removal.

oh, which stability features were you thinking of?
From my pov, the ones I was thinking of were a) reboot occasionally and b) retry
tasks with BOT_DIED, both of which were done.

> Keeping this setup makes it possible to revert
> back in case of catastrophic failure.

That's true; I had thought that worst case scenario we can just disable swarming
with one machine running tests. It will be slow, but given that we've been using
swarming for 2 months now, it seems very low risk. Also, if there is a big
failure, CQ being down seems just as bad as main waterfall, and either way cls
won't be landing. I don't feel strongly if you want to keep the machines for
now, but just wanted to let you know what was my reasoning.

Powered by Google App Engine
This is Rietveld 408576698