Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 598463002: Move --custom-launcher-page switch into app_list_switches.h. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 2 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move --custom-launcher-page switch into app_list_switches.h. This CL moves the --custom-launcher-page switch into app_list_switches.h because it probably belongs there with the other app list related switches. BUG=416756 Committed: https://crrev.com/9362bcbeaff8185dc8a452e7048f9917c56f6edf Cr-Commit-Position: refs/heads/master@{#297373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
6 years, 2 months ago (2014-09-30 05:46:22 UTC) #2
Matt Giuca
lgtm
6 years, 2 months ago (2014-09-30 06:06:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598463002/1
6 years, 2 months ago (2014-09-30 06:09:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 90b6beb670fd3df85c80c288aa7a300c3f704b7b
6 years, 2 months ago (2014-09-30 07:03:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 07:04:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9362bcbeaff8185dc8a452e7048f9917c56f6edf
Cr-Commit-Position: refs/heads/master@{#297373}

Powered by Google App Engine
This is Rietveld 408576698