Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: sdk/lib/io/http.dart

Issue 598453003: Add HttpServer:autoCompress option, to disable auto gzip compression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add 'To disable, ...' Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http.dart
diff --git a/sdk/lib/io/http.dart b/sdk/lib/io/http.dart
index f0c4282a228cd635f03d1ffa32a6f99872271c64..360e0e028aba11e5190fe9d17cd0a3a05f084086 100644
--- a/sdk/lib/io/http.dart
+++ b/sdk/lib/io/http.dart
@@ -179,6 +179,20 @@ abstract class HttpServer implements Stream<HttpRequest> {
HttpHeaders get defaultResponseHeaders;
/**
+ * Get and set if the [HttpServer] should auto-compress the content, when
Lasse Reichstein Nielsen 2014/09/23 07:24:52 Other documentation doesn't use "get and set". Thi
Anders Johnsen 2014/09/23 08:35:34 Done.
+ * possible.
+ *
+ * The [HttpServer] will only compress when the response is using chunked
+ * Transfer-Encoding and the incoming request has `gzip` set in the
+ * Accept-Encoding header.
+ *
+ * To disable, set to `false`.
Lasse Reichstein Nielsen 2014/09/23 07:24:52 Combine the two short paragrahps? "The default val
Anders Johnsen 2014/09/23 08:35:34 Done.
+ *
+ * The default value is `true`.
Søren Gjesse 2014/09/23 07:56:23 I know the current default is true, but we should
Anders Johnsen 2014/09/23 08:35:34 Done.
+ */
+ bool autoCompress;
Lasse Reichstein Nielsen 2014/09/23 07:24:52 If you can enable and disable it, should it still
Anders Johnsen 2014/09/23 08:35:34 Done.
+
+ /**
* Get or set the timeout used for idle keep-alive connections. If no further
* request is seen within [idleTimeout] after the previous request was
* completed, the connection is dropped.
« no previous file with comments | « no previous file | sdk/lib/io/http_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698