Issue 59843012: Introduce DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS, and use it

Issue 59843012: Introduce DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS, and use it (Closed)

Created:
7 years, 1 month ago by gyuyoung-inactive

Modified:
7 years, 1 month ago

Reviewers:
tkent

CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS, and use it As a step to let toFoo use DEFINE_TYPE_CASTS, this cl introduce DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS, which can support more helper functions rather than manual toFoo(). This cl will help to detect bad type casts further. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161431

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -20 lines)			Patch
M	Source/core/rendering/svg/RenderSVGResource.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceClipper.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceMarker.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceMasker.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceRadialGradient.h	View	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/59843012/1

7 years, 1 month ago (2013-11-06 06:00:27 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=15807

7 years, 1 month ago (2013-11-06 07:16:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/59843012/1

7 years, 1 month ago (2013-11-06 07:43:40 UTC) #5

Message was sent while issue was closed.

Change committed as 161431

Expand Messages | Collapse Messages