Print to Privet local printers (PDF only)

Print to Privet local printers

This is a first iteration of printing to a Privet local printer. It only
supports PDFs. PWG rasterization will be added separately.

BUG=311390
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234126

[Vitaly Buka (NO REVIEWS), 2013-11-06 07:45:51]

lgtm

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/data/destination_store.js (right):

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
chrome/browser/resources/print_preview/data/destination_store.js:254:
this.nativeLayer_.startGetLocalDestinationCapabilities(
Here you need to get caps for selected privet printer

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/native_layer.js (right):

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:360:
chrome.send('manageCloudPrinters');
remove space

[Noam Samuel, 2013-11-06 18:43:54]

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/data/destination_store.js (right):

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
chrome/browser/resources/print_preview/data/destination_store.js:254:
this.nativeLayer_.startGetLocalDestinationCapabilities(
On 2013/11/06 07:45:51, Vitaly Buka wrote:
> Here you need to get caps for selected privet printer

Will do in separate CL so that this and the sticky printer CL don't have an
ordering constraint.

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/native_layer.js (right):

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:360:
chrome.send('manageCloudPrinters');
On 2013/11/06 07:45:51, Vitaly Buka wrote:
> remove space

Done.

[Vitaly Buka (NO REVIEWS), 2013-11-06 18:45:32]

lgtm

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/data/destination_store.js (right):

https://codereview.chromium.org/59843010/diff/30001/chrome/browser/resources/...
chrome/browser/resources/print_preview/data/destination_store.js:254:
this.nativeLayer_.startGetLocalDestinationCapabilities(
ok

On 2013/11/06 18:43:55, Noam Samuel wrote:
> On 2013/11/06 07:45:51, Vitaly Buka wrote:
> > Here you need to get caps for selected privet printer
> 
> Will do in separate CL so that this and the sticky printer CL don't have an
> ordering constraint.

[Toscano, 2013-11-06 22:05:35]

lgtm

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/native_layer.js (right):

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:676:
NativeLayer.EventType.PRIVET_CAPABILITIES_SET);
Needs two more spaces indent.

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:688:
NativeLayer.EventType.PRIVET_PRINT_FAILED);
Needs two more spaces indent.

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:688:
NativeLayer.EventType.PRIVET_PRINT_FAILED);
Should break on higher order operator:

var privetPrintFailedEvent =
    new Event(NativeLayer.EventType.PRIVET_PRINT_FAILED);

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/print_preview.js:820: this.close_();
Instead of closing, wouldn't you rather show an error to the user? As is done in
onCloudPrintError_:

this.printHeader_.setErrorMessage(event.message);

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/print_preview.js:822: 
Please remove extraneous newline.

[Noam Samuel, 2013-11-06 23:59:10]

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/native_layer.js (right):

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:676:
NativeLayer.EventType.PRIVET_CAPABILITIES_SET);
On 2013/11/06 22:05:35, Toscano wrote:
> Needs two more spaces indent.

Done.

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/native_layer.js:688:
NativeLayer.EventType.PRIVET_PRINT_FAILED);
On 2013/11/06 22:05:35, Toscano wrote:
> Should break on higher order operator:
> 
> var privetPrintFailedEvent =
>     new Event(NativeLayer.EventType.PRIVET_PRINT_FAILED);

Done.

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
File chrome/browser/resources/print_preview/print_preview.js (right):

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/print_preview.js:820: this.close_();
On 2013/11/06 22:05:35, Toscano wrote:
> Instead of closing, wouldn't you rather show an error to the user? As is done
in
> onCloudPrintError_:
> 
> this.printHeader_.setErrorMessage(event.message);

Done.

https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
chrome/browser/resources/print_preview/print_preview.js:822: 
On 2013/11/06 22:05:35, Toscano wrote:
> Please remove extraneous newline.

Done.

[Vitaly Buka (NO REVIEWS), 2013-11-08 07:12:55]

On 2013/11/06 23:59:10, Noam Samuel wrote:
>
https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
> File chrome/browser/resources/print_preview/native_layer.js (right):
> 
>
https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
> chrome/browser/resources/print_preview/native_layer.js:676:
> NativeLayer.EventType.PRIVET_CAPABILITIES_SET);
> On 2013/11/06 22:05:35, Toscano wrote:
> > Needs two more spaces indent.
> 
> Done.
> 
>
https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
> chrome/browser/resources/print_preview/native_layer.js:688:
> NativeLayer.EventType.PRIVET_PRINT_FAILED);
> On 2013/11/06 22:05:35, Toscano wrote:
> > Should break on higher order operator:
> > 
> > var privetPrintFailedEvent =
> >     new Event(NativeLayer.EventType.PRIVET_PRINT_FAILED);
> 
> Done.
> 
>
https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
> File chrome/browser/resources/print_preview/print_preview.js (right):
> 
>
https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
> chrome/browser/resources/print_preview/print_preview.js:820: this.close_();
> On 2013/11/06 22:05:35, Toscano wrote:
> > Instead of closing, wouldn't you rather show an error to the user? As is
done
> in
> > onCloudPrintError_:
> > 
> > this.printHeader_.setErrorMessage(event.message);
> 
> Done.
> 
>
https://codereview.chromium.org/59843010/diff/90001/chrome/browser/resources/...
> chrome/browser/resources/print_preview/print_preview.js:822: 
> On 2013/11/06 22:05:35, Toscano wrote:
> > Please remove extraneous newline.
> 
> Done.

Please set BUG=

[Noam Samuel, 2013-11-08 23:12:43]

Updated the CL description to reflect the fact that it sends the ticket (since
the CL to send tickets landed before it did).

[commit-bot: I haz the power, 2013-11-08 23:13:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/59843010/260001

[commit-bot: I haz the power, 2013-11-09 06:42:38]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-09 07:51:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/59843010/260001

[commit-bot: I haz the power, 2013-11-09 17:23:40]

Change committed as 234126