Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: tools/push-to-trunk/common_includes.py

Issue 598403003: Refactoring: Remove unnecessary logic from push_to_trunk. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/push-to-trunk/push_to_trunk.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 the V8 project authors. All rights reserved. 2 # Copyright 2013 the V8 project authors. All rights reserved.
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following 10 # copyright notice, this list of conditions and the following
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 def RemoteMasterBranch(self): 330 def RemoteMasterBranch(self):
331 return "svn/bleeding_edge" 331 return "svn/bleeding_edge"
332 332
333 def RemoteCandidateBranch(self): 333 def RemoteCandidateBranch(self):
334 return "svn/trunk" 334 return "svn/trunk"
335 335
336 def RemoteBranch(self, name): 336 def RemoteBranch(self, name):
337 return "svn/%s" % name 337 return "svn/%s" % name
338 338
339 def Land(self): 339 def Land(self):
340 return self.step.GitSVNDCommit() 340 self.step.GitSVNDCommit()
341 341
342 def CLLand(self): 342 def CLLand(self):
343 return self.step.GitDCommit() 343 self.step.GitDCommit()
344 344
345 def Tag(self, tag): 345 def Tag(self, tag):
346 self.step.GitSVNTag(tag) 346 self.step.GitSVNTag(tag)
347 347
348 348
349 349
350 class Step(GitRecipesMixin): 350 class Step(GitRecipesMixin):
351 def __init__(self, text, number, config, state, options, handler): 351 def __init__(self, text, number, config, state, options, handler):
352 self._text = text 352 self._text = text
353 self._number = number 353 self._number = number
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 for (number, step_class) in enumerate(step_classes): 791 for (number, step_class) in enumerate(step_classes):
792 steps.append(MakeStep(step_class, number, self._state, self._config, 792 steps.append(MakeStep(step_class, number, self._state, self._config,
793 options, self._side_effect_handler)) 793 options, self._side_effect_handler))
794 for step in steps[options.step:]: 794 for step in steps[options.step:]:
795 if step.Run(): 795 if step.Run():
796 return 0 796 return 0
797 return 0 797 return 0
798 798
799 def Run(self, args=None): 799 def Run(self, args=None):
800 return self.RunSteps(self._Steps(), args) 800 return self.RunSteps(self._Steps(), args)
OLDNEW
« no previous file with comments | « no previous file | tools/push-to-trunk/push_to_trunk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698