Issue 598403003: Refactoring: Remove unnecessary logic from push_to_trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 598403003: Refactoring: Remove unnecessary logic from push_to_trunk. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach

Modified:
6 years, 2 months ago

Reviewers:
tandrii(chromium), Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Refactoring: Remove unnecessary logic from push_to_trunk. Remove some svnish things that are output-only. BUG=chromium:410721 LOG=n TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24231

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -25 lines)			Patch
M	tools/push-to-trunk/common_includes.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	2 chunks	+1 line, -21 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Michael Achenbach

Committed patchset #1 (id:1) manually as 24231 (tree was closed).

6 years, 2 months ago (2014-09-25 14:09:43 UTC) #3

Message was sent while issue was closed.

lgtm