Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 598393002: Apply automatic range checks to /chrome enum types across IPC. (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
jam, nasko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to /chrome enum types across IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/bca743c6d94f14cecd9b9834b8e8e806c7ef9067 Cr-Commit-Position: refs/heads/master@{#297135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/render_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/search_provider.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
nasko@chromium.org: Please review changes in message.h change jam@chromium.org: Please review changes in chrome module
6 years, 2 months ago (2014-09-25 10:07:55 UTC) #2
nasko
LGTM
6 years, 2 months ago (2014-09-25 16:28:16 UTC) #3
jam
lgtm
6 years, 2 months ago (2014-09-26 19:45:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598393002/1
6 years, 2 months ago (2014-09-29 02:56:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 66a9664859650b6b6938b1d098e835f1686af0b0
6 years, 2 months ago (2014-09-29 03:52:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 03:53:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bca743c6d94f14cecd9b9834b8e8e806c7ef9067
Cr-Commit-Position: refs/heads/master@{#297135}

Powered by Google App Engine
This is Rietveld 408576698