editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java - Issue 598383004: Issue 14476. Use DartSDK to open files for debugger URIs like dart:async/future.dart in Editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java

Issue 598383004: Issue 14476. Use DartSDK to open files for debugger URIs like dart:async/future.dart in Editor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/dartium/DartiumSourcePathComputerDelegate.java ('k') | editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerSourcePathComputerDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java

diff --git a/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java b/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java

index ee110261bd3b53b5a109201c4983603bc2413fc3..1b8f1d3d73ba80a61e5dbca4e8eb1a14845f2a4a 100644

--- a/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java

+++ b/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugStackFrame.java

@@ -265,6 +265,14 @@ public class ServerDebugStackFrame extends ServerDebugElement implements IStackF

uri = resolvePackageUri(wrapper.getApplicationResource(), uri);

}

+ // handle dart:lib/lib.dart in DartSdkSourceContainer,

+ // exclude "_patch.dart" files, they don't exist as files in sdk/lib folder

+ if (uri != null && "dart".equals(uri.getScheme())) {

+ if (!uri.getSchemeSpecificPart().endsWith("_patch.dart")) {

+ return uri.toString();

+ }

if (uri != null && "file".equals(uri.getScheme())) {

return uri.getPath();

} else {