Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 598353003: Handle the "debug_devtools" build arg in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make use of the "debug_devtools" config added on the Blink side Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/BUILD.gn
diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn
index 9404d4bdf6248eeb328a871c634bfbcf3d7905f4..0d2d4ab1f4d855aea5dfa32b038352e347c44df0 100644
--- a/chrome/browser/devtools/BUILD.gn
+++ b/chrome/browser/devtools/BUILD.gn
@@ -40,17 +40,14 @@ static_library("devtools") {
]
sources += get_target_outputs(":devtools_protocol_constants")
- # TODO(GYP)
- # ['debug_devtools==1', {
- # 'defines': [
- # 'DEBUG_DEVTOOLS=1',
- # ],
- # }],
if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
cflags = [ "/wd4267" ]
}
- configs += [ "//build/config/compiler:wexit_time_destructors" ]
+ configs += [
+ "//build/config/compiler:wexit_time_destructors",
+ "//third_party/WebKit/public:debug_devtools",
+ ]
deps = [
":devtools_protocol_constants",
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698