Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/devtools/BUILD.gn

Issue 598353003: Handle the "debug_devtools" build arg in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni")
6
5 action("devtools_protocol_constants") { 7 action("devtools_protocol_constants") {
6 script = "//content/public/browser/devtools_protocol_constants_generator.py" 8 script = "//content/public/browser/devtools_protocol_constants_generator.py"
7 9
8 blink_protocol = "//third_party/WebKit/Source/devtools/protocol.json" 10 blink_protocol = "//third_party/WebKit/Source/devtools/protocol.json"
9 browser_protocol = "//content/browser/devtools/browser_protocol.json" 11 browser_protocol = "//content/browser/devtools/browser_protocol.json"
10 inputs = [ blink_protocol, browser_protocol ] 12 inputs = [ blink_protocol, browser_protocol ]
11 outputs = [ 13 outputs = [
12 "$target_gen_dir/devtools_protocol_constants.cc", 14 "$target_gen_dir/devtools_protocol_constants.cc",
13 "$target_gen_dir/devtools_protocol_constants.h", 15 "$target_gen_dir/devtools_protocol_constants.h",
14 ] 16 ]
15 17
16 args = [ "chrome" ] 18 args = [ "chrome" ]
17 args += rebase_path(outputs, root_build_dir) 19 args += rebase_path(outputs, root_build_dir)
18 args += [ rebase_path(blink_protocol, root_build_dir) ] 20 args += [ rebase_path(blink_protocol, root_build_dir) ]
19 args += [ rebase_path(browser_protocol, root_build_dir) ] 21 args += [ rebase_path(browser_protocol, root_build_dir) ]
20 } 22 }
21 23
22 # GYP version: chrome/chrome_debugger.gypi:debugger 24 # GYP version: chrome/chrome_debugger.gypi:debugger
23 static_library("devtools") { 25 static_library("devtools") {
26 defines = []
27
24 # Note: new sources and deps should be generally added in (!is_android) below. 28 # Note: new sources and deps should be generally added in (!is_android) below.
25 sources = [ 29 sources = [
26 "devtools_network_conditions.cc", 30 "devtools_network_conditions.cc",
27 "devtools_network_conditions.h", 31 "devtools_network_conditions.h",
28 "devtools_network_controller.cc", 32 "devtools_network_controller.cc",
29 "devtools_network_controller.h", 33 "devtools_network_controller.h",
30 "devtools_network_interceptor.cc", 34 "devtools_network_interceptor.cc",
31 "devtools_network_interceptor.h", 35 "devtools_network_interceptor.h",
32 "devtools_network_protocol_handler.cc", 36 "devtools_network_protocol_handler.cc",
33 "devtools_network_protocol_handler.h", 37 "devtools_network_protocol_handler.h",
34 "devtools_network_transaction.cc", 38 "devtools_network_transaction.cc",
35 "devtools_network_transaction.h", 39 "devtools_network_transaction.h",
36 "devtools_network_transaction_factory.cc", 40 "devtools_network_transaction_factory.cc",
37 "devtools_network_transaction_factory.h", 41 "devtools_network_transaction_factory.h",
38 "devtools_protocol.cc", 42 "devtools_protocol.cc",
39 "devtools_protocol.h" 43 "devtools_protocol.h"
40 ] 44 ]
41 sources += get_target_outputs(":devtools_protocol_constants") 45 sources += get_target_outputs(":devtools_protocol_constants")
42 46
43 # TODO(GYP) 47 if (debug_devtools) {
44 # ['debug_devtools==1', { 48 defines += [ "DEBUG_DEVTOOLS=1" ]
brettw 2014/09/25 20:40:53 It would be nice to have a config somewhere that d
apavlov 2014/09/26 07:10:27 Good point. I've got https://codereview.chromium.o
45 # 'defines': [ 49 }
46 # 'DEBUG_DEVTOOLS=1', 50
47 # ],
48 # }],
49 if (is_win) { 51 if (is_win) {
50 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 52 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
51 cflags = [ "/wd4267" ] 53 cflags = [ "/wd4267" ]
52 } 54 }
53 configs += [ "//build/config/compiler:wexit_time_destructors" ] 55 configs += [ "//build/config/compiler:wexit_time_destructors" ]
54 56
55 deps = [ 57 deps = [
56 ":devtools_protocol_constants", 58 ":devtools_protocol_constants",
57 "//base", 59 "//base",
58 "//content/public/browser", 60 "//content/public/browser",
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 "devtools_toggle_action.h", 119 "devtools_toggle_action.h",
118 "devtools_ui_bindings.cc", 120 "devtools_ui_bindings.cc",
119 "devtools_ui_bindings.h", 121 "devtools_ui_bindings.h",
120 "devtools_window.cc", 122 "devtools_window.cc",
121 "devtools_window.h", 123 "devtools_window.h",
122 "remote_debugging_server.cc", 124 "remote_debugging_server.cc",
123 "remote_debugging_server.h" 125 "remote_debugging_server.h"
124 ] 126 ]
125 } 127 }
126 } 128 }
OLDNEW
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698