Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 598353002: X87: fix the bug which is introduced by R24169. (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: fix the bug which is introduced by R24169. Two more DeoptimizeIf(...) are added so the branch distance changed. we need to use Label::kFar. BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
WL. PTAL. thanks
6 years, 2 months ago (2014-09-25 08:29:20 UTC) #2
Weiliang
lgtm https://codereview.chromium.org/598353002/diff/1/src/x87/lithium-codegen-x87.cc File src/x87/lithium-codegen-x87.cc (right): https://codereview.chromium.org/598353002/diff/1/src/x87/lithium-codegen-x87.cc#newcode5308 src/x87/lithium-codegen-x87.cc:5308: __ jmp(&done, Label::kFar); The default jmp is far. ...
6 years, 2 months ago (2014-09-25 12:56:55 UTC) #3
Weiliang
Committed as r24226
6 years, 2 months ago (2014-09-25 12:57:58 UTC) #4
Sven Panne
Hmmm, I think this is still fragile: On x87 deopts emit much more code than ...
6 years, 2 months ago (2014-09-29 07:15:58 UTC) #5
Weiliang
6 years, 2 months ago (2014-09-29 08:14:09 UTC) #6
On 2014/09/29 07:15:58, Sven Panne wrote:
> Hmmm, I think this is still fragile: On x87 deopts emit much more code than on
> other platforms, so is it really safe to do *any* near jump in DoDoubleToI?

Agree. It is still fragile here. We'd better to use the far jump in DoDoubleToI.
Thanks a lot.

Thanks
-Weiliang

Powered by Google App Engine
This is Rietveld 408576698