Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 598333003: Fix uninitialized memory error in CastTransport. (Closed)

Created:
6 years, 2 months ago by Kevin M
Modified:
6 years, 2 months ago
Reviewers:
mark a. foltz, oshima, miu, Wez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, bruening+watch_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized memory error in CastTransport. Reenable Valgrind runs for CastTransport unit tests. R=miu,oshima BUG=418767 TBR=wez@chromium.org Committed: https://crrev.com/30c32fdc78a8d4e00a8aeec5015a674e64e36195 Cr-Commit-Position: refs/heads/master@{#297483}

Patch Set 1 #

Patch Set 2 : Code review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M extensions/browser/api/cast_channel/cast_transport.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Kevin M
6 years, 2 months ago (2014-09-30 00:23:38 UTC) #2
oshima
lgtm
6 years, 2 months ago (2014-09-30 00:38:37 UTC) #3
miu
lgtm
6 years, 2 months ago (2014-09-30 03:39:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598333003/20001
6 years, 2 months ago (2014-09-30 03:44:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14321)
6 years, 2 months ago (2014-09-30 03:52:49 UTC) #8
Kevin M
Need a LGTM from wez@ or mfoltz@. We should probably get a third OWNER registered ...
6 years, 2 months ago (2014-09-30 16:56:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598333003/20001
6 years, 2 months ago (2014-09-30 18:36:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e880ad2e73ccf9af839adde5a88494d004e148fa
6 years, 2 months ago (2014-09-30 19:44:03 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/30c32fdc78a8d4e00a8aeec5015a674e64e36195 Cr-Commit-Position: refs/heads/master@{#297483}
6 years, 2 months ago (2014-09-30 19:45:19 UTC) #14
Wez
6 years, 2 months ago (2014-09-30 21:45:22 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698