Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: content/renderer/p2p/port_allocator.cc

Issue 598323002: Use of base::StringPairs appropriately in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/p2p/port_allocator.cc
diff --git a/content/renderer/p2p/port_allocator.cc b/content/renderer/p2p/port_allocator.cc
index 53a71e2b8047675cd4813c550d22ee5c00c0ef95..01004b0227c4569b9e03e440245134ade7b30d0d 100644
--- a/content/renderer/p2p/port_allocator.cc
+++ b/content/renderer/p2p/port_allocator.cc
@@ -202,7 +202,8 @@ void P2PPortAllocatorSession::AllocateLegacyRelaySession() {
}
void P2PPortAllocatorSession::ParseRelayResponse() {
- std::vector<std::pair<std::string, std::string> > value_pairs;
+ //std::vector<std::pair<std::string, std::string> > value_pairs;
Avi (use Gerrit) 2014/09/25 04:59:15 remove
MRV 2014/09/25 05:15:28 Done.
+ base::StringPairs value_pairs;
if (!base::SplitStringIntoKeyValuePairs(relay_session_response_, '=', '\n',
&value_pairs)) {
LOG(ERROR) << "Received invalid response from relay server";
@@ -214,7 +215,8 @@ void P2PPortAllocatorSession::ParseRelayResponse() {
relay_tcp_port_ = 0;
relay_ssltcp_port_ = 0;
- for (std::vector<std::pair<std::string, std::string> >::iterator
+ //for (std::vector<std::pair<std::string, std::string> >::iterator
Avi (use Gerrit) 2014/09/25 04:59:15 remove
MRV 2014/09/25 05:15:28 Done.
+ for (base::StringPairs::iterator
it = value_pairs.begin();
Avi (use Gerrit) 2014/09/25 04:59:15 combine lines
MRV 2014/09/25 05:15:28 Done.
it != value_pairs.end(); ++it) {
std::string key;
« content/browser/transition_request_manager.cc ('K') | « content/common/websocket.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698