Use of base::StringPairs appropriately in content

Use of base::StringPairs appropriately in content

Using  base::StringPairs in base folder
Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250
Committed: https://crrev.com/0079fbabc4baef46e50f587f0f4012b76517960f
Cr-Commit-Position: refs/heads/master@{#296676}

[MRV, 2014-09-25 04:53:25]

mohan.reddy@samsung.com changed reviewers:
+ avi@chromium.org

[MRV, 2014-09-25 04:53:26]

PTAL

[Avi (use Gerrit), 2014-09-25 04:59:16]

https://codereview.chromium.org/598323002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/598323002/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility.cc:176: const
base::StringPairs&
This was already broken, but functions in .cc files should return the same types
as declared in the .h files. Make this be

const HtmlAttributes&

instead.

https://codereview.chromium.org/598323002/diff/1/content/browser/transition_r...
File content/browser/transition_request_manager.cc (right):

https://codereview.chromium.org/598323002/diff/1/content/browser/transition_r...
content/browser/transition_request_manager.cc:94:
//std::vector<std::pair<std::string, std::string> > attributes;
Do not commit commented-out lines.

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
File content/renderer/p2p/port_allocator.cc (right):

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
content/renderer/p2p/port_allocator.cc:205: //std::vector<std::pair<std::string,
std::string> > value_pairs;
remove

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
content/renderer/p2p/port_allocator.cc:218: //for
(std::vector<std::pair<std::string, std::string> >::iterator
remove

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
content/renderer/p2p/port_allocator.cc:220: it = value_pairs.begin();
combine lines

[MRV, 2014-09-25 05:15:28]

Dear Mr. avi, thanks for comments I have incorporated the changes suggested by
you.
PTAL

https://codereview.chromium.org/598323002/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/598323002/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility.cc:176: const
base::StringPairs&
On 2014/09/25 04:59:15, Avi wrote:
> This was already broken, but functions in .cc files should return the same
types
> as declared in the .h files. Make this be
> 
> const HtmlAttributes&
> 
> instead.

Done.

https://codereview.chromium.org/598323002/diff/1/content/browser/transition_r...
File content/browser/transition_request_manager.cc (right):

https://codereview.chromium.org/598323002/diff/1/content/browser/transition_r...
content/browser/transition_request_manager.cc:94:
//std::vector<std::pair<std::string, std::string> > attributes;
On 2014/09/25 04:59:15, Avi wrote:
> Do not commit commented-out lines.

Done.

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
File content/renderer/p2p/port_allocator.cc (right):

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
content/renderer/p2p/port_allocator.cc:205: //std::vector<std::pair<std::string,
std::string> > value_pairs;
On 2014/09/25 04:59:15, Avi wrote:
> remove

Done.

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
content/renderer/p2p/port_allocator.cc:218: //for
(std::vector<std::pair<std::string, std::string> >::iterator
On 2014/09/25 04:59:15, Avi wrote:
> remove

Done.

https://codereview.chromium.org/598323002/diff/1/content/renderer/p2p/port_al...
content/renderer/p2p/port_allocator.cc:220: it = value_pairs.begin();
On 2014/09/25 04:59:15, Avi wrote:
> combine lines

Done.

[Avi (use Gerrit), 2014-09-25 05:34:45]

lgtm

[MRV, 2014-09-25 05:35:47]

On 2014/09/25 05:34:45, Avi wrote:
> lgtm

Thanks Mr. avi for LGTM

[MRV, 2014-09-25 05:35:52]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-25 05:37:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598323002/20001

[commit-bot: I haz the power, 2014-09-25 05:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 05:52:46]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[MRV, 2014-09-25 06:30:57]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-25 06:31:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/598323002/40001

[commit-bot: I haz the power, 2014-09-25 07:25:31]

Committed patchset #3 (id:40001) as b9001dc584774c930ea8ad352c1ef70d32226746

[commit-bot: I haz the power, 2014-09-25 07:26:14]

Patchset 3 (id:??) landed as
https://crrev.com/0079fbabc4baef46e50f587f0f4012b76517960f
Cr-Commit-Position: refs/heads/master@{#296676}