Chromecast: adds CastNetworkDelegate.

chromecast/chromecast.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'chromecast_branding%': 'Chromium',
   },
   'target_defaults': {
@@ skipping 84 matching lines @@
         'net/network_change_notifier_cast.cc',
         'net/network_change_notifier_cast.h',
         'net/network_change_notifier_factory_cast.cc',
         'net/network_change_notifier_factory_cast.h',
       ],
     },
     {
       'target_name': 'cast_service',
       'type': '<(component)',
       'dependencies': [
+        'cast_common',
         '../skia/skia.gyp:skia',
       ],
       'sources': [
+        'service/cast_network_delegate.cc',
+        'service/cast_network_delegate.h',

[lcwu1, 2014/09/25 18:53:18]

I think it makes more sense for the network delegate files to be in either
chromecast/shell/browser (like what chrome or content shell dose) or maybe in
chromecast/net (as the base class in in net/base). And they should be in
cast_shell_common target.

[gunsch, 2014/09/25 19:24:59]

I disagree. See my internal CL. ChromecastService depends on
CastNetworkDelegate, which it's a layering violation for us. This was already a
layering violation before I merged it internally and moved it from the
cast_shell and cast_shell_internal targets to
cast_service/cast_service_internal.

[lcwu1, 2014/09/25 20:07:04]

ChromecastService should not depend on CastNetworkDelegate. The network delegate
should be used (called) inside content's network requests. If Cast service has
to depend on network delegate, then there is something wrong that we need to
fix.

Basically I don't see network delegate as part of the cast service. It should be
part of the content embedder.

[gunsch, 2014/09/25 20:46:34]

Done.

         'service/cast_service.cc',
         'service/cast_service.h',
       ],
       'conditions': [
         ['chromecast_branding=="Chrome"', {
           'dependencies': [
             'internal/chromecast_internal.gyp:cast_service_internal',
           ],
         }, {
           'dependencies': [
             '../base/base.gyp:base',
             '../content/content.gyp:content',
           ],
+          'sources': [
+            'service/cast_network_delegate_simple.cc',
+          ],
           'conditions': [
             ['OS=="android"', {
               'sources': [
                 'service/cast_service_android.cc',
                 'service/cast_service_android.h',
               ],
             }, {
               'sources': [
                 'service/cast_service_simple.cc',
                 'service/cast_service_simple.h',
@@ skipping 333 matching lines @@
           'sources': [
             'shell/browser/test/chromecast_browser_test.cc',
             'shell/browser/test/chromecast_browser_test.h',
             'shell/browser/test/chromecast_browser_test_runner.cc',
           ],
         },
       ],  # end of targets
     }],
   ],  # end of conditions
 }