Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 598253002: Revert of [AiS] Merge answers into highest-scoring result (Closed)

Created:
6 years, 3 months ago by jiayl
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@top-hit
Project:
chromium
Visibility:
Public.

Description

Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/) Reason for revert: The new tests are flaky: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944 Original issue's description: > [AiS] Merge answers into highest-scoring result > > Answer contents and type must always be copied to the highest-scoring > suggestion, to ensure answers are not lost due to suggestion > deduplication. > > BUG=415836 > R=mpearson > > Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922 > Cr-Commit-Position: refs/heads/master@{#296520} TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org NOTREECHECKS=true NOTRY=true BUG=415836 Committed: https://crrev.com/ba5d32190d4f056b11738b050b94895b655c52f7 Cr-Commit-Position: refs/heads/master@{#296555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -204 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox/base_search_provider.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D components/omnibox/base_search_provider_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jiayl
Created Revert of [AiS] Merge answers into highest-scoring result
6 years, 3 months ago (2014-09-24 23:04:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598253002/1
6 years, 3 months ago (2014-09-24 23:05:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f54fe5bad0f8d3b6cc7bb5e3817bc9da2a68aa48
6 years, 3 months ago (2014-09-24 23:07:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ba5d32190d4f056b11738b050b94895b655c52f7 Cr-Commit-Position: refs/heads/master@{#296555}
6 years, 3 months ago (2014-09-24 23:08:12 UTC) #4
jiayl
6 years, 3 months ago (2014-09-24 23:22:03 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/599273002/ by jiayl@chromium.org.

The reason for reverting is: Broken GN build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/bu....

Powered by Google App Engine
This is Rietveld 408576698