Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: third_party/libpng/BUILD.gn

Issue 598233002: GN: Change libpng to be a group rather than a static_library, since it has no sources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("libpng_config") { 5 config("libpng_config") {
6 include_dirs = [ 6 include_dirs = [
7 ".", 7 ".",
8 ] 8 ]
9 9
10 defines = [ 10 defines = [
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 defines = [ "PNG_BUILD_DLL" ] 63 defines = [ "PNG_BUILD_DLL" ]
64 } 64 }
65 } 65 }
66 66
67 public_configs = [ ":libpng_config" ] 67 public_configs = [ ":libpng_config" ]
68 68
69 public_deps = [ "//third_party/zlib" ] 69 public_deps = [ "//third_party/zlib" ]
70 } 70 }
71 71
72 if (is_win) { 72 if (is_win) {
73 component("libpng") { 73 component("libpng") {
Robert Sesek 2014/09/24 22:28:54 Is it correct to use public_deps with component()
brettw 2014/09/24 22:30:56 Yes, this is fine. An argument could be made that
74 public_deps = [ ":libpng_sources" ] 74 public_deps = [ ":libpng_sources" ]
75 } 75 }
76 } else { 76 } else {
77 static_library("libpng") { 77 group("libpng") {
78 public_deps = [ ":libpng_sources" ] 78 public_deps = [ ":libpng_sources" ]
79 } 79 }
80 } 80 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698