Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 59823008: Remove deprecated v8-defaults.h and defaults.cc. (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove deprecated v8-defaults.h and defaults.cc. BUG=312241 LOG=Y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17909

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -127 lines) Patch
D include/v8-defaults.h View 1 chunk +0 lines, -48 lines 0 comments Download
M src/d8.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
D src/defaults.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Sven, please take a look.
7 years, 1 month ago (2013-11-18 20:57:17 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-11-19 09:05:34 UTC) #2
rmcilroy
7 years, 1 month ago (2013-11-20 11:20:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698