Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 598223004: [NaCl SDK] nacl_io: add return value to nacl_io_init. (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@mem_leaks
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: add return value to nacl_io_init. The underlying ki_init functions were returning their success but for some reason nacl_io_init was ignoring this and returning void. Committed: https://crrev.com/9ae3cc379b1aef7d6ae76f1eedc773d297489e07 Cr-Commit-Position: refs/heads/master@{#296752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 2 chunks +6 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.h View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
6 years, 3 months ago (2014-09-24 23:55:43 UTC) #2
binji
lgtm
6 years, 3 months ago (2014-09-24 23:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598223004/1
6 years, 2 months ago (2014-09-25 15:53:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/60692) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/65579) android_aosp ...
6 years, 2 months ago (2014-09-25 15:57:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598223004/1
6 years, 2 months ago (2014-09-25 17:41:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca602b9be9ba16c08791cd2bf3e1820d7f259273
6 years, 2 months ago (2014-09-25 19:04:36 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:05:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ae3cc379b1aef7d6ae76f1eedc773d297489e07
Cr-Commit-Position: refs/heads/master@{#296752}

Powered by Google App Engine
This is Rietveld 408576698