Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 598223003: Update base::is_member_function_pointer to use variadic templates. (Closed)

Created:
6 years, 2 months ago by Aaron Boodman
Modified:
6 years, 2 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update base::is_member_function_pointer to use variadic templates. BUG= Committed: https://crrev.com/489d67130b22457a2c9ee7b6671cc105bf5204c3 Cr-Commit-Position: refs/heads/master@{#296817}

Patch Set 1 #

Patch Set 2 : remove extraneous tests #

Patch Set 3 : update comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -51 lines) Patch
M base/template_util.h View 1 2 1 chunk +6 lines, -28 lines 0 comments Download
M base/template_util_unittest.cc View 1 2 chunks +2 lines, -23 lines 2 comments Download

Messages

Total messages: 14 (4 generated)
Aaron Boodman
6 years, 2 months ago (2014-09-25 21:46:48 UTC) #2
Aaron Boodman
6 years, 2 months ago (2014-09-25 22:01:34 UTC) #4
Mark Mentovai
This should go to thakis or ajwong. I seem to have been left out of ...
6 years, 2 months ago (2014-09-25 22:03:04 UTC) #5
Aaron Boodman
6 years, 2 months ago (2014-09-25 22:10:12 UTC) #7
Nico
lgtm from SFO, away for realz soon > This should go to thakis or ajwong. ...
6 years, 2 months ago (2014-09-25 22:19:12 UTC) #8
Mark Mentovai
On 2014/09/25 22:19:12, Nico (away until Oct 27) wrote: > lgtm from SFO, away for ...
6 years, 2 months ago (2014-09-25 22:32:37 UTC) #9
Aaron Boodman
https://codereview.chromium.org/598223003/diff/40001/base/template_util_unittest.cc File base/template_util_unittest.cc (left): https://codereview.chromium.org/598223003/diff/40001/base/template_util_unittest.cc#oldcode127 base/template_util_unittest.cc:127: IsMemberFunctionPointer); On 2014/09/25 22:19:11, Nico (away until Oct 27) ...
6 years, 2 months ago (2014-09-25 22:34:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598223003/40001
6 years, 2 months ago (2014-09-25 22:36:57 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 5a2810b27c7e103e0c1cd9cc1d0234c407c67f15
6 years, 2 months ago (2014-09-25 23:06:35 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:07:57 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/489d67130b22457a2c9ee7b6671cc105bf5204c3
Cr-Commit-Position: refs/heads/master@{#296817}

Powered by Google App Engine
This is Rietveld 408576698