Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 598223002: Add missing _ASSIGN() macro in NaCl's sys/socket.h (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
noelallen1, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing _ASSIGN() macro in NaCl's sys/socket.h Some macros in sys/socket.h were using _ASSING() macro, which wasn't defined anywhere. BUG=402993 Committed: https://crrev.com/5912a1fdbadb3176a004e117d4a3ff15567dfa8e Cr-Commit-Position: refs/heads/master@{#296621}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M native_client_sdk/src/libraries/third_party/newlib-extras/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/third_party/newlib-extras/sys/socket.h View 1 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-24 22:28:01 UTC) #2
Sam Clegg
I recently added the same thing to naclports: https://chromium.googlesource.com/external/naclports/+/d814530ee8217cb91bb4c6a151147fad1bde6681%5E%21/#F7 Can you take the macros from ...
6 years, 3 months ago (2014-09-24 23:19:16 UTC) #4
Sergey Ulanov
On 2014/09/24 23:19:16, Sam Clegg wrote: > I recently added the same thing to naclports: ...
6 years, 3 months ago (2014-09-25 00:17:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598223002/40001
6 years, 3 months ago (2014-09-25 00:20:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 52d0c1112ecf783947d768faa557b83360735c3c
6 years, 3 months ago (2014-09-25 01:55:56 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 01:56:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5912a1fdbadb3176a004e117d4a3ff15567dfa8e
Cr-Commit-Position: refs/heads/master@{#296621}

Powered by Google App Engine
This is Rietveld 408576698