extensions/common/manifest_handlers/launcher_page_info.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/launcher_page_info.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/common/manifest_handlers/icons_handler.cc ('k') | extensions/common/manifest_handlers/nacl_modules_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/launcher_page_info.cc

diff --git a/extensions/common/manifest_handlers/launcher_page_info.cc b/extensions/common/manifest_handlers/launcher_page_info.cc

index 0e1afea72b7aaee448b85843799827581ee3ddcf..ad3ed2614f5e84eda46f012e4758f99c65e1e5d3 100644

--- a/extensions/common/manifest_handlers/launcher_page_info.cc

+++ b/extensions/common/manifest_handlers/launcher_page_info.cc

@@ -28,7 +28,7 @@ LauncherPageInfo* LauncherPageHandler::GetInfo(const Extension* extension) {

bool LauncherPageHandler::Parse(Extension* extension, base::string16* error) {

const extensions::Manifest* manifest = extension->manifest();

scoped_ptr<LauncherPageInfo> launcher_page_info(new LauncherPageInfo);

- const base::DictionaryValue* launcher_page_dict = NULL;

+ const base::DictionaryValue* launcher_page_dict = nullptr;

if (!manifest->GetDictionary(manifest_keys::kLauncherPage,

&launcher_page_dict)) {

*error = base::ASCIIToUTF16(manifest_errors::kInvalidLauncherPage);