extensions/browser/api/runtime/runtime_apitest.cc - Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/runtime/runtime_apitest.cc

Issue 598173003: Run clang-modernize -use-nullptr over src/extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/bluetooth/bluetooth_apitest.cc ('K') | « extensions/browser/api/runtime/runtime_api.cc ('k') | extensions/browser/api/serial/serial_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/runtime/runtime_apitest.cc

diff --git a/extensions/browser/api/runtime/runtime_apitest.cc b/extensions/browser/api/runtime/runtime_apitest.cc

index 764e22e28894554179530d5fbf809243ba82a661..93d42d25449fa7e61a51de3577ca2e3ee043b1ed 100644

--- a/extensions/browser/api/runtime/runtime_apitest.cc

+++ b/extensions/browser/api/runtime/runtime_apitest.cc

@@ -47,10 +47,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeGetPlatformInfo) {

scoped_ptr<base::Value> result(

extension_function_test_utils::RunFunctionAndReturnSingleResult(

new RuntimeGetPlatformInfoFunction(), "[]", browser()));

- ASSERT_TRUE(result.get() != NULL);

+ ASSERT_TRUE(result.get() != nullptr);

base::DictionaryValue* dict =

extension_function_test_utils::ToDictionary(result.get());

- ASSERT_TRUE(dict != NULL);

+ ASSERT_TRUE(dict != nullptr);

EXPECT_TRUE(dict->HasKey("os"));

EXPECT_TRUE(dict->HasKey("arch"));

EXPECT_TRUE(dict->HasKey("nacl_arch"));