Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 598163003: <webview>: Zooming the embedder should zoom the guest by the same level. (Closed)

Created:
6 years, 2 months ago by Fady Samuel
Modified:
6 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

<webview>: Zooming the embedder should zoom the guest by the same level. Note: Currently this solution is implemented in the chrome module but once ZoomController moves to extensions, zooming from embedder to guest should move to GuestViewBase and a more general solution should be made available for GuestView types that wish to receive this zoom plumbing. BUG=416581 Committed: https://crrev.com/4253aba6222fecb87d07eebe50a2e34a034fb19c Cr-Commit-Position: refs/heads/master@{#296540}

Patch Set 1 #

Patch Set 2 : Updated comments #

Patch Set 3 : Fixed spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 2 4 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
6 years, 2 months ago (2014-09-24 20:51:46 UTC) #2
xiyuan
LGTM Thank you for the quick fix.
6 years, 2 months ago (2014-09-24 20:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598163003/40001
6 years, 2 months ago (2014-09-24 21:15:30 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 60304758b9bae5d05287d40209b48418c7188d84
6 years, 2 months ago (2014-09-24 22:11:05 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 22:11:33 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4253aba6222fecb87d07eebe50a2e34a034fb19c
Cr-Commit-Position: refs/heads/master@{#296540}

Powered by Google App Engine
This is Rietveld 408576698