Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7366)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.h

Issue 598163002: [Win] Redesign the new avatar button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_strip.h
diff --git a/chrome/browser/ui/views/tabs/tab_strip.h b/chrome/browser/ui/views/tabs/tab_strip.h
index 25f3610e3d2f1c594908d2b35845f93023100889..e89d512fc21d59f914bbea22b51fab17afa5ff0b 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.h
+++ b/chrome/browser/ui/views/tabs/tab_strip.h
@@ -257,6 +257,13 @@ class TabStrip : public views::View,
// Returns preferred height in immersive style.
static int GetImmersiveHeight();
+ // The size of the new tab button must be hardcoded because we need to be
+ // able to lay it out before we are able to get its image from the
+ // ui::ThemeProvider. It also makes sense to do this, because the size of the
+ // new tab button should not need to be calculated dynamically.
+ static const int kNewTabButtonAssetWidth;
sky 2014/09/26 03:45:16 constants should be first in a section (see style
noms (inactive) 2014/09/26 16:03:42 Done.
+ static const int kNewTabButtonAssetHeight;
+
private:
typedef std::vector<Tab*> Tabs;
typedef std::map<int, Tabs> TabsClosingMap;
@@ -310,13 +317,6 @@ class TabStrip : public views::View,
// Horizontal gap between mini and non-mini-tabs.
static const int kMiniToNonMiniGap;
- // The size of the new tab button must be hardcoded because we need to be
- // able to lay it out before we are able to get its image from the
- // ui::ThemeProvider. It also makes sense to do this, because the size of the
- // new tab button should not need to be calculated dynamically.
- static const int kNewTabButtonAssetWidth;
- static const int kNewTabButtonAssetHeight;
-
void Init();
// Creates and returns a new tab. The caller owners the returned tab.

Powered by Google App Engine
This is Rietveld 408576698