[Win] Redesign the new avatar button.

chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Index: chrome/browser/ui/views/frame/glass_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
index 116a7b9d9615873522555058e4b0375d03c8cfb6..3e59d005b02916fe089b3fe23a5e7099e52e3858 100644
--- a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
@@ -112,7 +112,15 @@ gfx::Rect GlassBrowserFrameView::GetBoundsForTabStrip(
   // minimize button.
   if (new_avatar_button()) {
     DCHECK(switches::IsNewAvatarMenu());
-    minimize_button_offset -= new_avatar_button()->width();
+    minimize_button_offset -=

[sky, 2014/09/24 23:21:39]

I'm confused here. Shouldn't you only adjust the button_offset if not maximized?
In other words, why bother with the size of the new tab button. The new assets
are designed to fit over it, so we shouldn't have to do any adjustments, right?

[noms (inactive), 2014/09/25 14:06:18]

The new tab button fits under it, but not the tabs. So in the non maximized
case, if we are showing the profile name, we need to only allow the new tab
button, but not the tabs, to slide under:
https://drive.google.com/open?id=0B1B1Up4p2NRMVGx1VXJhU2liaDg&authuser=1

In the maximized case, you still need to calculate the size of the buttons so
that the tabs stop before the avatar/caption buttons (since they're all on one
line)

+        new_avatar_button()->width() + kNewAvatarButtonOffset;
+
+    // In non-maximized mode, allow the new tab button to completely slide under
+    // the avatar button.
+    if (!frame()->IsMaximized() && !base::i18n::IsRTL()) {
+      minimize_button_offset +=
+          TabStrip::kNewTabButtonAssetWidth + kNewTabCaptionRestoredSpacing;
+    }
   }
 
   int tabstrip_x = browser_view()->ShouldShowAvatar() ?