Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 598133002: Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas (Closed)

Created:
6 years, 3 months ago by borenet
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@refactor_skImage
Project:
skia
Visibility:
Public.

Description

Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas (patchset #9 id:160001 of https://codereview.chromium.org/583453002/) Reason for revert: Broke ChromiumOS Ozone builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio Reverting to unblock DEPS roll. Original issue's description: > SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/432789972c1e1f8a66165c75a250dba1853efa08 TBR=junov@chromium.org,reed@google.com,bsalomon@google.com,piotaixr@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/2456b7681aea8d91072186b17f8209955846f2f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -91 lines) Patch
M gm/dftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/image.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M gm/multipicturedraw.cpp View 10 chunks +31 lines, -31 lines 0 comments Download
M include/core/SkCanvas.h View 4 chunks +2 lines, -10 lines 0 comments Download
M include/core/SkImage.h View 2 chunks +11 lines, -13 lines 0 comments Download
M samplecode/SampleTextureDomain.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 12 chunks +10 lines, -22 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
borenet
Created Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas
6 years, 3 months ago (2014-09-24 18:02:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598133002/1
6 years, 3 months ago (2014-09-24 18:03:22 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 18:03:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 2456b7681aea8d91072186b17f8209955846f2f7

Powered by Google App Engine
This is Rietveld 408576698