Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 59813007: [Android] Enable starting the crash upload service using an intent (Closed)

Created:
7 years, 1 month ago by frankf
Modified:
7 years, 1 month ago
Reviewers:
Yaron, Feng Qian
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Enable starting the crash upload service using an intent This utility can be used by stability tests to upload any crashers before the profile is cleared. BUG=None R=feng@chromium.org, yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235229

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added the call to monkey #

Patch Set 3 : Better logging for monkey #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M build/android/pylib/android_commands.py View 1 chunk +13 lines, -0 lines 0 comments Download
M build/android/pylib/monkey/test_runner.py View 1 2 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
frankf
7 years, 1 month ago (2013-11-14 02:55:55 UTC) #1
Feng Qian
https://codereview.chromium.org/59813007/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/59813007/diff/1/build/android/pylib/android_commands.py#newcode746 build/android/pylib/android_commands.py:746: '%s/%s.crash.MinidumpUploadService' % I think the service name is fixed, ...
7 years, 1 month ago (2013-11-14 18:22:20 UTC) #2
frankf
https://codereview.chromium.org/59813007/diff/1/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/59813007/diff/1/build/android/pylib/android_commands.py#newcode746 build/android/pylib/android_commands.py:746: '%s/%s.crash.MinidumpUploadService' % It is constant. Take a look at ...
7 years, 1 month ago (2013-11-14 18:57:32 UTC) #3
Yaron
lgtm
7 years, 1 month ago (2013-11-14 18:59:11 UTC) #4
Feng Qian
lgtm, thanks
7 years, 1 month ago (2013-11-14 20:11:48 UTC) #5
frankf
7 years, 1 month ago (2013-11-14 20:57:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r235229.

Powered by Google App Engine
This is Rietveld 408576698