Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 59813004: Adds support for the search key in the Virtual Keyboard. (Closed)

Created:
7 years, 1 month ago by rsadam
Modified:
7 years, 1 month ago
Reviewers:
kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds support for the search key in the Virtual Keyboard. We currently do not use the search key, but may need it in future layouts. BUG=315071 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M ui/keyboard/keyboard_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_ui_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key-codes.html View 1 chunk +1 line, -0 lines 0 comments Download
A ui/keyboard/resources/images/search.svg View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/keyboard/resources/layouts/function-key-row.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/main.css View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rsadam
7 years, 1 month ago (2013-11-13 15:57:57 UTC) #1
kevers
lgtm
7 years, 1 month ago (2013-11-18 17:42:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/59813004/1
7 years, 1 month ago (2013-11-18 17:44:24 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 20:21:50 UTC) #4
Message was sent while issue was closed.
Change committed as 235803

Powered by Google App Engine
This is Rietveld 408576698