Source/core/rendering/RenderListMarker.cpp - Issue 598113003: [Regression] Selections are incorrectly invalidated

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/RenderListMarker.cpp

Issue 598113003: [Regression] Selections are incorrectly invalidated (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed the test to be cross-platform Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/platform/win/fast/repaint/text-selection-rect-in-overflow-2-expected.txt ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.	4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.

5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)	5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)

6 * Copyright (C) 2010 Daniel Bates (dbates@intudata.com)	6 * Copyright (C) 2010 Daniel Bates (dbates@intudata.com)

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 1611 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1622	1622

1623 LayoutRect RenderListMarker::selectionRectForPaintInvalidation(const RenderLayer ModelObject* paintInvalidationContainer) const	1623 LayoutRect RenderListMarker::selectionRectForPaintInvalidation(const RenderLayer ModelObject* paintInvalidationContainer) const

1624 {	1624 {

1625 ASSERT(!needsLayout());	1625 ASSERT(!needsLayout());

1626	1626

1627 if (selectionState() == SelectionNone \|\| !inlineBoxWrapper())	1627 if (selectionState() == SelectionNone \|\| !inlineBoxWrapper())

1628 return LayoutRect();	1628 return LayoutRect();

1629	1629

1630 RootInlineBox& root = inlineBoxWrapper()->root();	1630 RootInlineBox& root = inlineBoxWrapper()->root();

1631 LayoutRect rect(0, root.selectionTop() - y(), width(), root.selectionHeight( ));	1631 LayoutRect rect(0, root.selectionTop() - y(), width(), root.selectionHeight( ));

1632	1632 mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, 0);

1633 return localToContainerQuad(FloatRect(rect), paintInvalidationContainer).enc losingBoundingBox();	1633 return rect;

1634 }	1634 }

1635	1635

1636 } // namespace blink	1636 } // namespace blink

OLD	NEW