Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 598093006: Fix IPCChannelMojoErrorTest.SendFailWithPendingMessages (Closed)

Created:
6 years, 3 months ago by Hajime Morrita
Modified:
6 years, 3 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix IPCChannelMojoErrorTest.SendFailWithPendingMessages The test has been broken since MojoBootstrap was introduced. The change makes it impossible to inject failure from the ChannelMojo subclass. This change uses large data as pending message to trigger failure, instead of overloading IPC::ChannelMojo functions. R=viettrungluu@chromium.org BUG=417439 Committed: https://crrev.com/be6c4ccb1377a0ffd5b31ef9b56b70474a126833 Cr-Commit-Position: refs/heads/master@{#296565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -46 lines) Patch
M ipc/mojo/ipc_channel_mojo_unittest.cc View 4 chunks +11 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Hajime Morrita
6 years, 3 months ago (2014-09-24 22:18:50 UTC) #1
Hajime Morrita
Trung: Could you take a look? A trivial test fix.
6 years, 3 months ago (2014-09-24 22:19:48 UTC) #2
viettrungluu
lgtm
6 years, 3 months ago (2014-09-24 22:28:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598093006/1
6 years, 3 months ago (2014-09-24 22:30:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8927f20831098339766965528b93db13778be8fa
6 years, 3 months ago (2014-09-24 23:38:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:47:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be6c4ccb1377a0ffd5b31ef9b56b70474a126833
Cr-Commit-Position: refs/heads/master@{#296565}

Powered by Google App Engine
This is Rietveld 408576698