ui/ozone/platform/dri/dri_surface.cc - Issue 598093004: Use SkCanvas::drawImageRect() instead of SkImage::draw()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/platform/dri/dri_surface.cc

Issue 598093004: Use SkCanvas::drawImageRect() instead of SkImage::draw() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/ozone/platform/dri/dri_surface.h"	5 #include "ui/ozone/platform/dri/dri_surface.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "base/message_loop/message_loop.h"	8 #include "base/message_loop/message_loop.h"

9 #include "third_party/skia/include/core/SkCanvas.h"	9 #include "third_party/skia/include/core/SkCanvas.h"

10 #include "third_party/skia/include/core/SkSurface.h"	10 #include "third_party/skia/include/core/SkSurface.h"

(...skipping 75 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86	86

87 void DriSurface::UpdateNativeSurface(const gfx::Rect& damage) {	87 void DriSurface::UpdateNativeSurface(const gfx::Rect& damage) {

88 SkCanvas* canvas = buffers_[front_buffer_ ^ 1]->GetCanvas();	88 SkCanvas* canvas = buffers_[front_buffer_ ^ 1]->GetCanvas();

89	89

90 // The DriSurface is double buffered, so the current back buffer is	90 // The DriSurface is double buffered, so the current back buffer is

91 // missing the previous update. Expand damage region.	91 // missing the previous update. Expand damage region.

92 SkRect real_damage = RectToSkRect(UnionRects(damage, last_damage_));	92 SkRect real_damage = RectToSkRect(UnionRects(damage, last_damage_));

93	93

94 // Copy damage region.	94 // Copy damage region.

95 skia::RefPtr<SkImage> image = skia::AdoptRef(surface_->newImageSnapshot());	95 skia::RefPtr<SkImage> image = skia::AdoptRef(surface_->newImageSnapshot());

96 image->draw(canvas, &real_damage, real_damage, NULL);	96 canvas->drawImageRect(image.get(), &real_damage, real_damage, NULL);

97	97

98 last_damage_ = damage;	98 last_damage_ = damage;

99 }	99 }

100	100

101 } // namespace ui	101 } // namespace ui

OLD	NEW