Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 598093003: Workaround telemetry CPU problem on Android. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
nduca, dtu, Sami, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Workaround telemetry CPU problem on Android. Some devices remove cpu related files from /proc when the cores are turned off. We assume the frequency is 0 if it's missing. BUG=417259 Committed: https://crrev.com/096c1e44db5723d9eacff072afa76b48f84728c5 Cr-Commit-Position: refs/heads/master@{#296492}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Sammi's commment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 1 3 chunks +10 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor_unittest.py View 1 6 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
nednguyen
6 years, 3 months ago (2014-09-24 17:37:04 UTC) #2
nednguyen
PTAL
6 years, 3 months ago (2014-09-24 17:37:19 UTC) #3
Sami
https://codereview.chromium.org/598093003/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/598093003/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode123 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:123: if 'No such file or directory' in sample[cpu]: Could ...
6 years, 3 months ago (2014-09-24 17:49:57 UTC) #4
nednguyen
https://codereview.chromium.org/598093003/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/598093003/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode123 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:123: if 'No such file or directory' in sample[cpu]: On ...
6 years, 3 months ago (2014-09-24 18:02:01 UTC) #5
nednguyen
6 years, 3 months ago (2014-09-24 18:13:06 UTC) #7
tonyg
lgtm
6 years, 3 months ago (2014-09-24 18:23:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598093003/40001
6 years, 3 months ago (2014-09-24 18:28:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 69fa8a7c88642321ea73b8352661b50ed2f534aa
6 years, 3 months ago (2014-09-24 19:40:45 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 19:41:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/096c1e44db5723d9eacff072afa76b48f84728c5
Cr-Commit-Position: refs/heads/master@{#296492}

Powered by Google App Engine
This is Rietveld 408576698