Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 598093002: Rename GN public variables. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Rename GN public variables. forward_dependent_configs_from => public_deps direct_dependent_configs => public_configs R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7a649fe262d77f93ad3213f53e973a7665d95a23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M BUILD.gn View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
brettw
6 years, 3 months ago (2014-09-24 17:25:34 UTC) #2
jam
lgtm
6 years, 2 months ago (2014-09-24 21:54:47 UTC) #3
brettw
6 years, 2 months ago (2014-09-24 22:32:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 7a649fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698