Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 598083006: Revert of Revert of Do not call run_webkit_tests.py in android buildbot scripts. (Closed)

Created:
6 years, 2 months ago by Mads Ager (chromium)
Modified:
6 years, 2 months ago
Reviewers:
cmp, Dirk Pranke, tfarina
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #1 id:1 of https://codereview.chromium.org/609713002/) Reason for revert: That revert was apparrently a really bad idea. Now all the bots are failing. Reverting the revert and hoping that will bring us back to one failing bot. Original issue's description: > Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/) > > Reason for revert: > Makes the webkit_lint step fail on android bots: > > @@@BUILD_STEP webkit_lint@@@ > > /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release > Usage: lint-test-expectations [options] > > lint-test-expectations: error: no such option: --target > < /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release > ERROR: process exited with code 2 > @@@STEP_FAILURE@@@ > > Original issue's description: > > Do not call run_webkit_tests.py in android buildbot scripts. > > > > Replace its usage by lint-test-expectations and run-webkit-tests, both > > scripts found in third_party/WebKit/Tools/Scripts. > > > > BUG=338338 > > TEST=None > > R=dpranke@chromium.org,cmp@chromium.org > > > > Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10 > > Cr-Commit-Position: refs/heads/master@{#296883} > > TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=338338 > > Committed: https://crrev.com/ce392c3ccf021a094e21ffa3ca3babeb313b4821 > Cr-Commit-Position: refs/heads/master@{#296892} TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=338338 Committed: https://crrev.com/158f28459b30b23536a0b6dbbdfe7cbd976ebbb6 Cr-Commit-Position: refs/heads/master@{#296893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/android/buildbot/bb_device_steps.py View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (chromium)
Created Revert of Revert of Do not call run_webkit_tests.py in android buildbot scripts.
6 years, 2 months ago (2014-09-26 06:06:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598083006/1
6 years, 2 months ago (2014-09-26 06:07:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 016a8b784b5f094280765026bf16ee87e7d81fd8
6 years, 2 months ago (2014-09-26 06:07:31 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 06:08:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/158f28459b30b23536a0b6dbbdfe7cbd976ebbb6
Cr-Commit-Position: refs/heads/master@{#296893}

Powered by Google App Engine
This is Rietveld 408576698