Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: build/common.gypi

Issue 598073004: Proof of concept fixit rewriting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@virt-annotations
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | iteratively-fix.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2125 matching lines...) Expand 10 before | Expand all | Expand 10 after
2136 'grit_defines': ['-D', 'enable_service_discovery'], 2136 'grit_defines': ['-D', 'enable_service_discovery'],
2137 'enable_service_discovery%': 1 2137 'enable_service_discovery%': 1
2138 }], 2138 }],
2139 ['clang_use_chrome_plugins==1 and OS!="win"', { 2139 ['clang_use_chrome_plugins==1 and OS!="win"', {
2140 'clang_chrome_plugins_flags': [ 2140 'clang_chrome_plugins_flags': [
2141 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)' 2141 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
2142 ], 2142 ],
2143 'conditions': [ 2143 'conditions': [
2144 # TODO(dcheng): https://crbug.com/417463 -- work to enable this flag 2144 # TODO(dcheng): https://crbug.com/417463 -- work to enable this flag
2145 # on all platforms is currently underway. 2145 # on all platforms is currently underway.
2146 ['OS=="linux" or OS=="mac" or OS=="ios"', { 2146 ['OS=="linux" or OS=="mac" or OS=="ios" or OS=="android"', {
2147 'clang_chrome_plugins_flags': [ 2147 'clang_chrome_plugins_flags': [
2148 '-Xclang', 2148 '-Xclang',
2149 '-plugin-arg-find-bad-constructs', 2149 '-plugin-arg-find-bad-constructs',
2150 '-Xclang', 2150 '-Xclang',
2151 'strict-virtual-specifiers', 2151 'strict-virtual-specifiers',
2152 ], 2152 ],
2153 }], 2153 }],
2154 ], 2154 ],
2155 }], 2155 }],
2156 ['asan==1 or msan==1 or lsan==1 or tsan==1', { 2156 ['asan==1 or msan==1 or lsan==1 or tsan==1', {
(...skipping 3732 matching lines...) Expand 10 before | Expand all | Expand 10 after
5889 # settings in target dicts. SYMROOT is a special case, because many other 5889 # settings in target dicts. SYMROOT is a special case, because many other
5890 # Xcode variables depend on it, including variables such as 5890 # Xcode variables depend on it, including variables such as
5891 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5891 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5892 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5892 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5893 # files to appear (when present) in the UI as actual files and not red 5893 # files to appear (when present) in the UI as actual files and not red
5894 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5894 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5895 # and therefore SYMROOT, needs to be set at the project level. 5895 # and therefore SYMROOT, needs to be set at the project level.
5896 'SYMROOT': '<(DEPTH)/xcodebuild', 5896 'SYMROOT': '<(DEPTH)/xcodebuild',
5897 }, 5897 },
5898 } 5898 }
OLDNEW
« no previous file with comments | « no previous file | iteratively-fix.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698