Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/bots/pub.py

Issue 598073002: Don't run optimization-threshold-counter=5 tests on the pub bot (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/pub.py
===================================================================
--- tools/bots/pub.py (revision 40631)
+++ tools/bots/pub.py (working copy)
@@ -54,23 +54,15 @@
if build_info.system == 'windows':
common_args.append('-j1')
- opt_threshold = '--vm-options=--optimization-counter-threshold=5'
if build_info.mode == 'release':
bot.RunTest('pub and pkg ', build_info,
common_args + ['pub', 'pkg', 'docs'],
swallow_error=True)
- bot.RunTest('pub and pkg optimization counter thresshold 5', build_info,
- common_args + ['--append_logs', opt_threshold,
- 'pub', 'pkg', 'docs'],
- swallow_error=True)
else:
# Pub tests currently have a lot of timeouts when run in debug mode.
# See issue 18479
bot.RunTest('pub and pkg', build_info, common_args + ['pkg', 'docs'],
swallow_error=True)
- bot.RunTest('pub and pkg optimization counter threshold 5', build_info,
- common_args + ['--append_logs', opt_threshold, 'pkg', 'docs'],
- swallow_error=True)
if build_info.mode == 'release':
pkgbuild_build_info = bot.BuildInfo('none', 'vm', build_info.mode,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698