Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 598063002: chromium-cpp: Set status code on errors, so that the console can track them. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

chromium-cpp: Set status code on errors, so that the console can track them. BUG=none R=inferno@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2f7665a216be089fafd15e8a412aef70dc44b1aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M styleguide/c++/chromium-cpp/main.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
6 years, 3 months ago (2014-09-24 15:55:49 UTC) #2
inferno
lgtm
6 years, 3 months ago (2014-09-24 15:57:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2f7665a216be089fafd15e8a412aef70dc44b1aa Cr-Commit-Position: refs/heads/master@{#296429}
6 years, 3 months ago (2014-09-24 16:05:00 UTC) #4
Nico
6 years, 3 months ago (2014-09-24 16:05:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 2f7665a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698