Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 598053003: Switching to C++11 template syntax (Closed)

Created:
6 years, 3 months ago by Charlie
Modified:
6 years, 2 months ago
Reviewers:
rkc
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switching to C++11 template syntax Committed: https://crrev.com/9e65b890f4e1a5919ea537418634672212373fee Cr-Commit-Position: refs/heads/master@{#296761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_translations.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_translations.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/copresence/rpc/rpc_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Charlie
6 years, 3 months ago (2014-09-24 22:06:22 UTC) #2
rkc
If it passes all the bots, W00T! lgtm!
6 years, 3 months ago (2014-09-24 22:08:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598053003/1
6 years, 3 months ago (2014-09-24 23:20:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/2030) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18780)
6 years, 3 months ago (2014-09-24 23:39:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598053003/1
6 years, 2 months ago (2014-09-25 19:23:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2c6c64654e9b6f07bfc05f5f022409a55a3d3c6b
6 years, 2 months ago (2014-09-25 19:24:36 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:25:13 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9e65b890f4e1a5919ea537418634672212373fee
Cr-Commit-Position: refs/heads/master@{#296761}

Powered by Google App Engine
This is Rietveld 408576698