Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 598033004: Fixing flakiness of 2 AppActivityTest's (Closed)

Created:
6 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing flakiness of 2 AppActivityTest's This was caused by some very slow running trybots. If the test was running significantly slower than a second, a MemoryPressureNotifier event was able to be sent, which caused the ResourceManager to perform some asynchronous action which is not wanted for these unit tests. BUG=412537, 417189 TEST=AppActivityTes.TestUnloadProxyLocation, AppActivityTest.TestMultipleActivityUnloadLock Committed: https://crrev.com/d8cbcb4ebec718274aa5807ccfb785fb7cab275c Cr-Commit-Position: refs/heads/master@{#296545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M athena/content/app_activity_unittest.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 2 months ago (2014-09-24 20:06:48 UTC) #2
oshima
lgtm
6 years, 2 months ago (2014-09-24 21:40:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/598033004/1
6 years, 2 months ago (2014-09-24 21:48:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bacfd1327b0ed9fca39d5c3e4d06e819a5444f05
6 years, 2 months ago (2014-09-24 22:28:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 22:28:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8cbcb4ebec718274aa5807ccfb785fb7cab275c
Cr-Commit-Position: refs/heads/master@{#296545}

Powered by Google App Engine
This is Rietveld 408576698