Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: PRESUBMIT.py

Issue 598023006: Add browser test for initial languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 ( 162 (
163 'ScopedAllowIO', 163 'ScopedAllowIO',
164 ( 164 (
165 'New code should not use ScopedAllowIO. Post a task to the blocking', 165 'New code should not use ScopedAllowIO. Post a task to the blocking',
166 'pool or the FILE thread instead.', 166 'pool or the FILE thread instead.',
167 ), 167 ),
168 True, 168 True,
169 ( 169 (
170 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 170 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
171 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_loader\.cc$", 171 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_loader\.cc$",
172 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
173 "customization_document_browsertest\.cc$",
172 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 174 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
173 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 175 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
174 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 176 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
175 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$", 177 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$",
176 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 178 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
177 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 179 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
178 ), 180 ),
179 ), 181 ),
180 ( 182 (
181 'SkRefPtr', 183 'SkRefPtr',
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
1647 builders.extend(['cros_x86']) 1649 builders.extend(['cros_x86'])
1648 1650
1649 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1651 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1650 # unless they're .gyp(i) files as changes to those files can break the gyp 1652 # unless they're .gyp(i) files as changes to those files can break the gyp
1651 # step on that bot. 1653 # step on that bot.
1652 if (not all(re.search('^chrome', f) for f in files) or 1654 if (not all(re.search('^chrome', f) for f in files) or
1653 any(re.search('\.gypi?$', f) for f in files)): 1655 any(re.search('\.gypi?$', f) for f in files)):
1654 builders.extend(['android_aosp']) 1656 builders.extend(['android_aosp'])
1655 1657
1656 return GetDefaultTryConfigs(builders) 1658 return GetDefaultTryConfigs(builders)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698