Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: PRESUBMIT.py

Issue 598023006: Add browser test for initial languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/customization_document_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 ( 158 (
159 'ScopedAllowIO', 159 'ScopedAllowIO',
160 ( 160 (
161 'New code should not use ScopedAllowIO. Post a task to the blocking', 161 'New code should not use ScopedAllowIO. Post a task to the blocking',
162 'pool or the FILE thread instead.', 162 'pool or the FILE thread instead.',
163 ), 163 ),
164 True, 164 True,
165 ( 165 (
166 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 166 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
167 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_loader\.cc$", 167 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_loader\.cc$",
168 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
169 "customization_document_browsertest\.cc$",
168 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 170 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 171 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 172 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
171 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + 173 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +
172 r"simple_platform_shared_buffer_posix\.cc$", 174 r"simple_platform_shared_buffer_posix\.cc$",
173 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 175 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
174 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 176 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
175 ), 177 ),
176 ), 178 ),
177 ( 179 (
(...skipping 1567 matching lines...) Expand 10 before | Expand all | Expand 10 after
1745 builders.extend(['cros_x86']) 1747 builders.extend(['cros_x86'])
1746 1748
1747 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1749 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1748 # unless they're .gyp(i) files as changes to those files can break the gyp 1750 # unless they're .gyp(i) files as changes to those files can break the gyp
1749 # step on that bot. 1751 # step on that bot.
1750 if (not all(re.search('^chrome', f) for f in files) or 1752 if (not all(re.search('^chrome', f) for f in files) or
1751 any(re.search('\.gypi?$', f) for f in files)): 1753 any(re.search('\.gypi?$', f) for f in files)):
1752 builders.extend(['android_aosp']) 1754 builders.extend(['android_aosp'])
1753 1755
1754 return GetDefaultTryConfigs(builders) 1756 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/customization_document_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698