Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 598013003: Added views::ViewModelT<T>, a type-safe template version of ViewModel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@appsgridview-static-casts
Patch Set: Fix browser_test compile on ChromeOS (missing include). Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_view.h ('k') | chrome/browser/ui/views/tabs/stacked_tab_strip_layout.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
index 9960694472246211f67081064f3b25c62d93f04e..d80bd02ef7f0b228a5b63336badaa45cbe3df411 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
@@ -56,6 +56,7 @@
#include "extensions/common/switches.h"
#include "extensions/test/extension_test_message_listener.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/app_list/views/app_list_item_view.h"
#include "ui/app_list/views/apps_grid_view.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/window.h"
@@ -1633,7 +1634,8 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, DISABLED_DragAndDrop) {
ASSERT_TRUE(grid_view->has_drag_and_drop_host_for_test());
// There should be 2 items in our application list.
- const views::ViewModel* vm_grid = grid_view->view_model_for_test();
+ const views::ViewModelT<app_list::AppListItemView>* vm_grid =
+ grid_view->view_model_for_test();
EXPECT_EQ(2, vm_grid->view_size());
// Test #1: Drag an app list which does not exist yet item into the
@@ -1783,7 +1785,8 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestWithMultiMonitor,
ASSERT_TRUE(grid_view->has_drag_and_drop_host_for_test());
// There should be 2 items in our application list.
- const views::ViewModel* vm_grid = grid_view->view_model_for_test();
+ const views::ViewModelT<app_list::AppListItemView>* vm_grid =
+ grid_view->view_model_for_test();
EXPECT_EQ(2, vm_grid->view_size());
// Drag an app list item which does not exist yet in the shelf.
@@ -1957,7 +1960,8 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ClickItem) {
ash::test::AppListControllerTestApi(ash::Shell::GetInstance()).
GetRootGridView();
ASSERT_TRUE(grid_view);
- const views::ViewModel* vm_grid = grid_view->view_model_for_test();
+ const views::ViewModelT<app_list::AppListItemView>* vm_grid =
+ grid_view->view_model_for_test();
EXPECT_EQ(2, vm_grid->view_size());
gfx::Rect bounds_grid_1 = vm_grid->view_at(1)->GetBoundsInScreen();
// Test now that a click does create a new application tab.
« no previous file with comments | « ash/shelf/shelf_view.h ('k') | chrome/browser/ui/views/tabs/stacked_tab_strip_layout.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698